changed the dbt package version to a version that fixed a dremio time… #2033
Conversation
|
👋 @GuyEshdat |
WalkthroughSwitches dbt dependency from the published elementary package to a git-based dbt-data-reliability source by activating a specific revision in packages.yml and updating package-lock.yml accordingly. The previous elementary dependency is commented out. No code or public API changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
elementary/monitor/dbt_project/packages.yml (2)
4-5: Leave the released package commented out (good); plan to revert when a release exists.Looks fine. When a release with the fix is cut, switch back to
package: elementary-data/elementarywith a pinned version.
9-10: Good use of a pinned commit; add traceability and follow‑up note.Add a short comment linking the fix/issue (ELE‑5134) and a TODO to move to the next release tag once available.
- git: https://github.com/elementary-data/dbt-data-reliability.git - revision: 20b76374f7c1b6cc280af7652c720e6069499a19 + # ELE-5134: temporary pin includes Dremio timestamp precision fix + # TODO: replace with released package version when available + revision: 20b76374f7c1b6cc280af7652c720e6069499a19
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
elementary/monitor/dbt_project/package-lock.yml(1 hunks)elementary/monitor/dbt_project/packages.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: test / test
- GitHub Check: code-quality
🔇 Additional comments (2)
elementary/monitor/dbt_project/package-lock.yml (1)
4-6: Lockfile regenerated viadbt deps; revision and SHA1 matchpackages.yml,dbt_utilspinned to 0.8.6, no strayelementary-data/elementaryreferences. Use a version tag instead of a raw commit for easier maintenance.elementary/monitor/dbt_project/packages.yml (1)
2-3: Sanity-check dbt_utils dependency
Resolved to v0.8.6 (within [>=0.8.0,<0.9.0]). Ensure this version is compatible with your dbt core/adapter versions.
…stamp bug
Summary by CodeRabbit